-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor #233
Comments
I also think a rewrite in TypeScript would be beneficial from an ease-of-development perspective. I'd be happy to make a PR, but I understand not wanting to go that route. |
The main reason I usually don't want TypeScript is that it introduces a build-step. If |
@tommy-mitchell Should we release a new major version or do you intend to work on more items here? |
@sindresorhus sorry for the late response, I’ve been busy with work this past week. Probably not going to have much more time for another week or two, so I think we could release now and add e.g. subcommands in a minor version |
@sindresorhus thoughts on moving to TypeScript, now that we have a build step? We can use Rollup to emit the built JavaScript, and since a build is generated before testing, we can use |
👍 |
Per the discussion in #230 (comment), this is a tracker issue for a general refactor:
index.js
andtest.js
into different files #234)index.js
into separate source files (Separateindex.js
andtest.js
into different files #234)cli.pkg
(Optimize startup performance #104)importMeta
(Make options required #260)The readme doesn’t say that it’s required (Improve importMeta message -meow - The 'importMeta' option is required. Its value must be 'import.meta' at meow
#222 (comment))The text was updated successfully, but these errors were encountered: