Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor #233

Open
5 of 9 tasks
tommy-mitchell opened this issue Mar 28, 2023 · 6 comments
Open
5 of 9 tasks

Refactor #233

tommy-mitchell opened this issue Mar 28, 2023 · 6 comments

Comments

@tommy-mitchell
Copy link
Contributor

tommy-mitchell commented Mar 28, 2023

Per the discussion in #230 (comment), this is a tracker issue for a general refactor:

@tommy-mitchell
Copy link
Contributor Author

tommy-mitchell commented Mar 28, 2023

I also think a rewrite in TypeScript would be beneficial from an ease-of-development perspective. I'd be happy to make a PR, but I understand not wanting to go that route.

@sindresorhus
Copy link
Owner

The main reason I usually don't want TypeScript is that it introduces a build-step. If - Bundle dependencies ends up requiring a build-step, it may make sense to move to TypeScript.

@sindresorhus
Copy link
Owner

@tommy-mitchell Should we release a new major version or do you intend to work on more items here?

@tommy-mitchell
Copy link
Contributor Author

@sindresorhus sorry for the late response, I’ve been busy with work this past week. Probably not going to have much more time for another week or two, so I think we could release now and add e.g. subcommands in a minor version

@tommy-mitchell
Copy link
Contributor Author

@sindresorhus thoughts on moving to TypeScript, now that we have a build step? We can use Rollup to emit the built JavaScript, and since a build is generated before testing, we can use tsd on the built index.d.ts.

@sindresorhus
Copy link
Owner

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants