Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide JSDoc comments for flag properties #230

Merged

Conversation

tommy-mitchell
Copy link
Contributor

Adds JSDoc comments to each property of the type Flag so that Intellisense is provided when creating a flag:

image

@tommy-mitchell
Copy link
Contributor Author

I also added missing info to the flags JSDoc that was in the readme, and reordered the options to group similar concepts.

@tommy-mitchell
Copy link
Contributor Author

I'd like to help get #211 merged before the next release goes out. Should I open a new PR branched from it, or should it be reopened and I make PRs to its feature branch?

@sindresorhus
Copy link
Owner

Should I open a new PR branched from it,

New PR.

@sindresorhus sindresorhus merged commit c73c297 into sindresorhus:main Mar 24, 2023
@tommy-mitchell
Copy link
Contributor Author

@sindresorhus unless you'd want to get #229 or #221 merged before the next release, you're good to put it out. Adding subcommands will probably be better with some general refactoring (separating utilities/steps into separate files, doing the same with tests/some fixtures, etc). I think that would be a good time to work on things like bundling and making errors consistent as well. I'll open a draft PR for that soon.

@sindresorhus
Copy link
Owner

There's no rush in getting out a new version. It's going to be a major bump.

@tommy-mitchell tommy-mitchell mentioned this pull request Mar 28, 2023
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants