-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Duplicate Tag + Release created without v
Prefix
#738
Comments
v
Prefix not Added to Git Tagv
Prefix not Added to version in GitHub Release name
v
Prefix not Added to version in GitHub Release namev
Prefix
Definitely sounds wrong that two separate tags are being created. We use Might be that somewhere is hard-coding a 'v'. Probably the easiest workaround right now is to set the pnpm config value to 'v', until it's fixed. We probably should keep the no-prefix behaviour for pnpm but definitely shouldn't have two separate tags. |
Interesting, I think I may have found more information - during publishing it opens the browser to this URL, which is creating a new tag without the
|
@mmkal maybe line 11 here? np/source/release-task-helper.js Lines 1 to 18 in 4b3b599
|
Hm... my gut feel would be to add prefixes everywhere. Seems very surprising that if I use Even |
I mean more that we should respect |
Yeah, good question why it's returning something different. 🤔 I would lean towards doing the change as a patch release (even if it's technically a breaking change) since the behavior feels like a bug and creates unexpected release names on GitHub. Maybe @sindresorhus has an opinion. |
Thinking about it more, I now agree. We should just use It still must be a bug that there's a duplicate, but that's a separate, and smaller, problem. |
Opened a PR for it: #739. I also think that this should be considered a bugfix rather than a real breaking change. I will try it out on another package later this week. @karlhorky you should be able to also try it by adding something like FYI @sindresorhus |
Nice, I saw that #739 was reviewed and merged and released in I just tested From my side, this issue could be closed, but maybe @mmkal you still have identified another issue which is why we should keep it open? |
I suspect we'd have duplicate tags if someone manually set their tag-version-prefix. I haven't tested but let's keep open until someone can. |
Description
Publishing a new version of our package with
np@10.0.1
(withpnpm
) caused a missingv
prefix on the GitHub release name (observe the missingv
in the first URL below).Digging in deeper reveals that two Git tags were created
v1.1.0
and1.1.0
, one with GitHub Release with release notes, one without:stylelint-config-upleveled
Tags:Logs from the publish:
Is this intentional? I could not see this change in the 10.0.0 release notes
Maybe this was something introduced by the pnpm support PR by @mmkal or the followup pnpm commits by @tommy-mitchell?
Previous Behavior
The previous versions of
np
created tags with thev
prefix, such asv1.0.7
here:Steps to reproduce
stylelint-config-upleveled
by runningnp
v
prefix (without GitHub Release + release notes)v
prefix (and with GitHub Release + release notes)Expected behavior
Only a single tag + GitHub Release should be created, with a
v
prefix and containing the release notesEnvironment
np - 10.0.1
Node.js - 20.11.1
npm - 10.2.4
pnpm - 8.15.3
Git - 2.39.2
OS - macOS Sonoma 14.4
The text was updated successfully, but these errors were encountered: