Fix TypeScript type for the cancel method #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus I hope that you will accept this PR and publish a new version of this repo and of got. |
|
Don't do unrelated changes. |
rkesters
force-pushed
the
rkesters/bbTypes
branch
from
bb53c01 to
65a549e
Compare
|
@sindresorhus -- I removed the |
sindresorhus
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project uses @types/bluebird-global there is a type clash, this PR makes a simple change to the typings file to allow p-cancelable to co-exist with @types/bluebird-global.
correct the following
tscerror: