Allow onFailedAttempt to be async
#30
Conversation
Also aborts all retries if `onFailedAttempt` throws.
|
@sindresorhus any chance this could be merged? |
sindresorhus
changed the title
onFailedAttempt to be async
readme.md
Outdated
| }, | ||
| ``` | ||
|
|
||
| If `onFailedAttempt` throws, all retries will be aborted. |
There was a problem hiding this comment.
This text and example be added to https://github.com/sindresorhus/p-retry/pull/30/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9R96, not here.
You also need to keep https://github.com/sindresorhus/p-retry/blob/master/index.d.ts in sync.
There was a problem hiding this comment.
If
onFailedAttemptthrows, all retries will be aborted.
This needs to mention that the original promise will reject with this error.
There was a problem hiding this comment.
I've updated the docs but I'm not sure what changes to make to the .d.ts file, I don't really know any TypeScript, sorry.
There was a problem hiding this comment.
Just add the docs changes to the .d.ts file.
There was a problem hiding this comment.
I've added the change. Hopefully it's in the right place.
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Builds on #29 and adds tests & docs. Also wraps the invocation of
onFailedAttemptin atry/catchto avoidunhandledPromiseRejections if it throws.Fixes #27.