Unify checking for fullscreen availability #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screenfull now always provides an object that at least contains `enabled`, making a seperate check for `screenfull` being `false` unnecessary. Fixes sindresorhus#142
sindresorhus
changed the title
|
Thanks :) |
|
I don't agree with this change , see #173 you shouldnot split an interface with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenfull now always provides an object that at least contains enabled, making a seperate check for screenfull being false unnecessary.
Fixes #142
(Sidenote: I have no access to browsers that don't support fullscreen, so I couldn't verify the functionality. You've probably already considered the following but... that's why I would suggest applying for an open source account at saucelabs and writing a test that confirms availability or lack thereof across various browsers.)