Support running on server environments (#199) #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've upgraded to the latest version and it works great. Thanks! 🎉 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSR (server-side rendering) is popular these days. Currently it is difficult to import screenful in SvelteKit because the same code is executed both in the browser and on the server. However, screenfull currently errors if
documentdoes not exist. Hence, one has to fiddle around to ensure that it is only imported when running in the browser. I assume that this also applies to other SSR solutions like Next.js.This PR makes it so that screenfull doesn't error on import if
documentisundefined. If run on the server, screenful doesn't do anything of course (but that's fine :).Until this PR is merged, I can use version 5.2.0 which supported this use case. That said, it'd be nice to see it return in the newest version.
Fixes #199