Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add countAnsiEscapeCodes option #48

Merged
merged 5 commits into from
May 6, 2023

Conversation

fisker
Copy link
Contributor

@fisker fisker commented May 5, 2023

Same as sindresorhus/string-length#16, add an option to count ANSI escape codes.
Previously requested by #15, and Prettier do need count them.

@fisker
Copy link
Contributor Author

fisker commented May 5, 2023

#47 should fix the CI.

@sindresorhus
Copy link
Owner

Can you fix the conflict?

@sindresorhus
Copy link
Owner

CI is failing:

 index.test-d.ts:5:36
  ✖  5:36  Argument of type { ambiguousIsNarrow: false; } is not assignable to parameter of type Options.
  Property countAnsiEscapeCodes is missing in type { ambiguousIsNarrow: false; } but required in type Options.   
  ✖  6:55  Argument of type { countAnsiEscapeCodes: true; } is not assignable to parameter of type Options.
  Property ambiguousIsNarrow is missing in type { countAnsiEscapeCodes: true; } but required in type Options.  

  2 errors

@fisker
Copy link
Contributor Author

fisker commented May 6, 2023

Fixed.

@sindresorhus sindresorhus merged commit 6e6993b into sindresorhus:main May 6, 2023
@fisker fisker deleted the countAnsiEscapeCodes branch May 6, 2023 08:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants