Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: export SimplifyDeep #824

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

tommy-mitchell
Copy link
Contributor

OmitDeep is trying to import SimplifyDeep, which isn't exported:

import type {SimplifyDeep} from './merge-deep';

This is causing a build to fail in meow: https://github.com/sindresorhus/meow/actions/runs/8145322629/job/22261300690?pr=252#step:4:20


SimplifyDeep should probably be moved to internal.d.ts and have its own type tests added, but that can be done later.

@sindresorhus
Copy link
Owner

I wonder why this isn't caught by our CI...

@tommy-mitchell
Copy link
Contributor Author

Maybe it's tsd's defaults? Since the tsconfig ignores the test-d directory, it's being tested with moduleResolution: node:

type-fest/tsconfig.json

Lines 3 to 15 in 8bfcd75

"compilerOptions": {
"noEmit": true,
"target": "ES2019", // Node.js 12
"lib": [
"ES2020",
"DOM"
],
"exactOptionalPropertyTypes": true,
"skipLibCheck": false, // Ensures .d.ts files are checked: https://github.com/sindresorhus/tsconfig/issues/15
},
"exclude": [
"test-d/**/*"
]

@sindresorhus
Copy link
Owner

Yeah, that's probably it. Will be fixed when we move to ESM later this year.

@sindresorhus sindresorhus merged commit 2061925 into sindresorhus:main Mar 5, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants