Snake case #16
Merged
Snake case #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantgray
approved these changes
Oct 12, 2022
| @@ -81,7 +83,10 @@ def generate_base_schema(): | |||
|
|
|||
|
|
|||
|
|
|||
| def generate_metadata(schema, dimensions, metrics, field_exclusions): | |||
| def to_snakecase(name): | |||
| return re.sub(r'(?<!^)(?=[A-Z])', '_', name).lower() | |||
There was a problem hiding this comment.
regex is so obnoxious, but it looks good to me.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Transforms field names to be lowercase and snakecase, so that they will always match in the destination. The api field name is stored as metadata under
tap-ga4.api-field-namesto be used in requests.Manual QA steps
Risks
Rollback steps