Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[python] One more rename in prep for domainish pushdown #3026

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Leveraging PRs on #2407 the full domain will be gotten from C++ libtiledbsoma with a simple cast in the pybind11/Rcpp layers.

However I missed one naming spot in the pybind11 layer.

Notes for Reviewer:

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (fa1fcc6) to head (219e1c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          40       40              
  Lines        4096     4096              
==========================================
+ Hits         3672     3678       +6     
+ Misses        424      418       -6     
Flag Coverage Δ
python 89.79% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <100.00%> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

Thanks @nguyenv ! :)

@johnkerl johnkerl merged commit 11d5396 into main Sep 21, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/one-more-rename branch September 21, 2024 00:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants