Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[r] Push ndim down to C++ #3066

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[r] Push ndim down to C++ #3066

merged 1 commit into from
Sep 25, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 25, 2024 •
edited
Loading

Issue and/or context: #3058 #2406 [sc-55674]

Changes:

Notes for Reviewer:

mojaveazure
mojaveazure approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please remember to bump develop version and update changelog, then 🚢

@johnkerl johnkerl merged commit 29b0c77 into main Sep 25, 2024
14 checks passed
@johnkerl johnkerl deleted the kerl/r-ndim-pushdown branch September 25, 2024 20:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mojaveazure mojaveazure mojaveazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkerl @mojaveazure