Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[python] Update TileDB-SOMA to use the somacore release with spatial datatypes #3078

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Sep 26, 2024

This PR updates somacore and adds the new spatial types to TileDB-SOMA as empty classes that throw NotImplementedErrors. It updates Experiment and Measurement to match the updated somacore API.

Issues: #3043 #3042

These types are needed as placeholders for the type checking in
`Experiment` and `Measurement`.
@johnkerl johnkerl changed the title Update TileDB-SOMA to use the somacore release with spatial datatypes [python] Update TileDB-SOMA to use the somacore release with spatial datatypes Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 52 lines in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (424c897) to head (a8b079c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3078      +/-   ##
==========================================
- Coverage   89.79%   89.16%   -0.63%     
==========================================
  Files          41       45       +4     
  Lines        4107     4284     +177     
==========================================
+ Hits         3688     3820     +132     
- Misses        419      464      +45     
Flag Coverage Δ
python 89.16% <71.73%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.16% <71.73%> (-0.63%) ⬇️
libtiledbsoma ∅ <ø> (∅)

apis/python/src/tiledbsoma/_geometry_dataframe.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_multiscale_image.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_constants.py Outdated Show resolved Hide resolved
jp-dark and others added 3 commits September 27, 2024 07:44
Co-authored-by: Aaron Wolen <aaron@wolen.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
apis/python/src/tiledbsoma/_multiscale_image.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Show resolved Hide resolved
apis/python/src/tiledbsoma/_point_cloud.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_geometry_dataframe.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_scene.py Outdated Show resolved Hide resolved
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: Aaron Wolen <aaron@wolen.com>
Co-authored-by: Aaron Wolen <aaron@wolen.com>
Co-authored-by: Aaron Wolen <aaron@wolen.com>
@jp-dark
Copy link
Collaborator Author

jp-dark commented Sep 27, 2024

[sc-50277], [sc-50274]

@jp-dark jp-dark merged commit 95c2ba7 into main Sep 27, 2024
21 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants