-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[python] Ingest somacore
classes
#3307
base: main
Are you sure you want to change the base?
Conversation
e216405
to
9b5366f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
==========================================
+ Coverage 85.14% 85.41% +0.26%
==========================================
Files 53 56 +3
Lines 5568 6040 +472
==========================================
+ Hits 4741 5159 +418
- Misses 827 881 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like straightforward code motion (as intended!) -- looks good to me
Holding off on approval until we get the somacore PR merged & a release tagged
Accompanying SOMA "core" changes: single-cell-data/SOMA#244
It can be awkward having some implementations in that repo:
dask
kwarg toExperimentAxisQuery.to_anndata
; EAQ impl has lived in the core repo, to date, but arguably should notChanges:
Move files and classes from single-cell-data/SOMA to this repo:
_query.py
:Axis
AxisIndexer
AxisQueryResult
ExperimentAxisQuery
MatrixAxisQuery
JoinIDCache
_fast_csr.py
_eager_iter.py