Upgrade standalone plugin to v4 (#367)

* Upgrade standalone plugin to v4 * Upgrade webpack, fix typescript error in root configs * Various fixes
single-spa · Nov 9, 2022 · a287602 · a287602
1 parent a34fad7
commit a287602
Show file tree

Hide file tree

Showing 9 changed files with 1,031 additions and 1,235 deletions.
diff --git a/.changeset/nasty-eggs-visit.md b/.changeset/nasty-eggs-visit.md
@@ -0,0 +1,9 @@
+---
+"generator-single-spa": patch
+"single-spa-welcome": patch
+"webpack-config-single-spa": patch
+---
+
+- Upgrade standalone-single-spa-webpack-plugin to version 4, for multiple importMapUrls support
+- Upgrade webpack to 5.75.0, for Node 18 support
+- Fix typescript error with root configs related to System.import
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-pnpx pretty-quick --staged
+pnpm exec pretty-quick --staged
diff --git a/packages/generator-single-spa/src/react/templates/react.package.json b/packages/generator-single-spa/src/react/templates/react.package.json
@@ -36,7 +36,7 @@
     "jest-cli": "^27.0.6",
     "prettier": "^2.3.2",
     "pretty-quick": "^3.1.1",
-    "webpack": "^5.51.1",
+    "webpack": "^5.75.0",
     "webpack-cli": "^4.8.0",
     "webpack-config-single-spa-react": "^4.0.0",
     "webpack-dev-server": "^4.0.0",

diff --git a/packages/generator-single-spa/src/root-config/templates/root-config.package.json b/packages/generator-single-spa/src/root-config/templates/root-config.package.json
@@ -29,7 +29,7 @@
     "prettier": "^2.3.2",
     "pretty-quick": "^3.1.1",
     "serve": "^12.0.0",
-    "webpack": "^5.51.1",
+    "webpack": "^5.75.0",
     "webpack-cli": "^4.8.0",
     "webpack-config-single-spa": "^5.0.0",
     "webpack-dev-server": "^4.0.0",

diff --git a/packages/generator-single-spa/src/root-config/templates/src/root-config.ejs b/packages/generator-single-spa/src/root-config/templates/src/root-config.ejs
@@ -1,9 +1,9 @@
-import { registerApplication, start } from "single-spa";
+import { registerApplication, start<% if (typescript) {%>, LifeCycles<% }%> } from "single-spa";
 
 registerApplication({
   name: "@single-spa/welcome",
   app: () =>
-    System.import(
+    System.import<% if (typescript) {%><LifeCycles><% } %>(
       "https://unpkg.com/single-spa-welcome/dist/single-spa-welcome.js"
     ),
   activeWhen: ["/"],

diff --git a/packages/generator-single-spa/src/util-module/templates/util-module.package.json b/packages/generator-single-spa/src/util-module/templates/util-module.package.json
@@ -33,7 +33,7 @@
     "jest-cli": "^27.0.6",
     "prettier": "^2.3.2",
     "pretty-quick": "^3.1.1",
-    "webpack": "^5.51.1",
+    "webpack": "^5.75.0",
     "webpack-config-single-spa": "^5.0.0",
     "webpack-merge": "^5.8.0",
     "webpack-cli": "^4.8.0",

diff --git a/packages/single-spa-welcome/package.json b/packages/single-spa-welcome/package.json
@@ -54,7 +54,7 @@
     "single-spa-react": "^4.3.1",
     "style-loader": "^3.2.1",
     "ts-config-single-spa": "workspace:*",
-    "webpack": "^5.51.1",
+    "webpack": "^5.75.0",
     "webpack-cli": "^4.8.0",
     "webpack-config-single-spa-react": "workspace:*",
     "webpack-dev-server": "^4.0.0",

diff --git a/packages/webpack-config-single-spa/package.json b/packages/webpack-config-single-spa/package.json
@@ -25,12 +25,12 @@
     "babel-loader": "^8.2.2",
     "css-loader": "^5.2.7",
     "html-webpack-plugin": "^5.3.2",
-    "standalone-single-spa-webpack-plugin": "^3.0.0",
+    "standalone-single-spa-webpack-plugin": "^4.0.0",
     "style-loader": "^3.2.1",
     "systemjs-webpack-interop": "^2.3.7",
     "webpack-bundle-analyzer": "^4.4.2"
   },
   "devDependencies": {
-    "webpack": "^5.51.1"
+    "webpack": "^5.75.0"
   }
 }