fix: use @typescript-eslint/parser when react typescript #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 058abb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pmjhonwang
force-pushed
the
fix/eslint-typescript
branch
from
bd99d7c
to
5327435
Compare
pmjhonwang
force-pushed
the
fix/eslint-typescript
branch
from
6a307ce
to
058abb1
Compare
|
Hi @pmjhonwang I'd like to circle back to this. Do you think these changes are still valid today? Or any updates to make before merging? Thanks again for your contribution! |
thx for CR |
filoxo
approved these changes
May 11, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe should I support both @babel/eslint-parser and @typescript-eslint/parser via eslint overrides?