Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't used named exports when exporting in ES Module format. #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manbearwiz
Copy link

@manbearwiz manbearwiz commented Nov 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Currently, setting "libraryTarget": "module" emits the following error:

Error: Library name must be unset. Common configuration options that specific library names are 'output.library[.name]', 'entry.xyz.library[.name]', 'ModuleFederationPlugin.name' and 'ModuleFederationPlugin.library[.name]'.

What is the new behavior?

The error is no longer emitted.

Does this PR introduce a breaking change?

  • No

@arturovt
Copy link
Member

Tests are failing. Could you have a look?

@manbearwiz
Copy link
Author

I noticed the failing e2e tests when I first made the PR. Those tests run inconsistently on my machine for main so I assumed this was an unrelated issue. Have you seen this before? I only ask because this change really only effect projects with "libraryTarget": "module" which doesn't include the e2e test projects.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants