Error feedback for unexpected value in constructLayoutEngine #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
reviewed
Jun 17, 2021
joeldenning
reviewed
Jun 17, 2021
src/browser/constructLayoutEngine.js
Outdated
|
|
||
| if (!resolvedRoutes) | ||
| throw Error( | ||
| `unexpected value passed to the "routes"-attribute on constructLayoutEngine. Value was ${typeof resolvedRoutes}` |
There was a problem hiding this comment.
Suggested change
| `unexpected value passed to the "routes"-attribute on constructLayoutEngine. Value was ${typeof resolvedRoutes}` | |
| `single-spa-layout: constructLayoutEngine opts.routes must be provided. Value was ${typeof resolvedRoutes}` |
joeldenning
approved these changes
Jun 17, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to get a
TypeError: Cannot read property 'base' of undefinedwhen using theconstructLayoutEnginefunction. Thought it would be nice to add a check which gives some helpful feedback for users in the future who may do the same mistake.