Update tests.py #36
Open
Update tests.py #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to change line 116 to get the assert to compare properly. They were "equal", but in different types.
The left had side was a string array of 99 characters: "[0, 20, 117, 30, 118, 232, 25, 145, 150, 212, 84, 148, 28, 69, 209, 179, 163, 35, 241, 67, 59, 214]"
The right hand side was a 22 character string: \x00\x14u\x1ev\xe8\x19\x91\x96\xd4T\x94\x1cE\xd1\xb3\xa3#\xf1C;\xd6
Runnings tests.py gave me the following before the proposed change:
F.
======================================================================
FAIL: test_valid_address (__main__.TestSegwitAddress)
Test whether valid addresses decode to the correct output.
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests.py", line 118, in test_valid_address
self.assertEqual(scriptpubkey, binascii.unhexlify(hexscript))
AssertionError: '[0, 20, 117, 30, 118, 232, 25, 145, 150, 212, 84, 148, 28, 69, 209, 179, 163, 35, 241, 67, 59, 214]' != '\x00\x14u\x1ev\xe8\x19\x91\x96\xd4T\x94\x1cE\xd1\xb3\xa3#\xf1C;\xd6'
----------------------------------------------------------------------
Ran 5 tests in 0.016s
With the change I get:
>python tests.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.016s
OK
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change line 116 to get the assert to compare properly. They were "equal", but in different types.
The left had side was a string array of 99 characters: "[0, 20, 117, 30, 118, 232, 25, 145, 150, 212, 84, 148, 28, 69, 209, 179, 163, 35, 241, 67, 59, 214]"
The right hand side was a 22 character string: \x00\x14u\x1ev\xe8\x19\x91\x96\xd4T\x94\x1cE\xd1\xb3\xa3#\xf1C;\xd6
Runnings tests.py gave me the following before the proposed change:
FAIL: test_valid_address (main.TestSegwitAddress)
Test whether valid addresses decode to the correct output.
Traceback (most recent call last):
File "tests.py", line 118, in test_valid_address
self.assertEqual(scriptpubkey, binascii.unhexlify(hexscript))
AssertionError: '[0, 20, 117, 30, 118, 232, 25, 145, 150, 212, 84, 148, 28, 69, 209, 179, 163, 35, 241, 67, 59, 214]' != '\x00\x14u\x1ev\xe8\x19\x91\x96\xd4T\x94\x1cE\xd1\xb3\xa3#\xf1C;\xd6'
Ran 5 tests in 0.016s
With the change I get:
Ran 5 tests in 0.016s
OK