-
Notifications
You must be signed in to change notification settings - Fork 16
Needs performance guard CI process #343
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Not sure if it would help, but PHPCS itself offers a Performance report As for improving performance, PHPCSUtils can help with that as any repeated calls to utility functions with the same arguments will get cached results within a single runtime (for most functions), which can often save a lot of processing. |
Note: the Performance report is only available in PHPCS 3.8.0+. |
Ah, that's cool! Yeah, I'd like to just make a job that runs a timing check and makes sure that the total time is not greater than X. In this case, the performance before #334 was about |
Maybe run I'm thinking a variation of these steps (but then with phpcs & the Performance report, store the time output to phpcs-variable-analysis/.github/workflows/test.yml Lines 195 to 214 in eb2b351
|
We need to add a CI task that guards against major performance regressions like #340
The text was updated successfully, but these errors were encountered: