-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add perf-guard github workflow #345
Conversation
Nice, I need to pick a better target file but this does work. You can see the failure in 769bd71 when I reduced to baseline time to 0.2. |
Was just thinking - I imagine that as things are now, it may be hard to debug the workflow when it fails as it may not be clear on what timing it failed.
|
Good thinking! I got that to work, I believe, although I still had to collect the output, print it, and grep it in the same step because I can't figure out how to pass a multi-line github output variable through grep. I figured out how to store the multi-line output in an output variable but then echoing it back into a unix pipe seems very difficult 🤔 . Hopefully a single step will be ok for now. |
I cheated and dumped the output to a file. That works. |
@sirbrillig Nicely done ;-) |
This adds a new Github action CI check to make sure that the performance of the sniff does not jump wildly high.
It uses the
PHPMailer.php
file from here: https://raw.githubusercontent.com/PHPMailer/PHPMailer/refs/tags/v6.9.3/src/PHPMailer.php as a test fixture, since that file is relatively large and complex. It then sets a threshold for scanning that file with this sniff.Fixes #343