Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modals Don't Close After Navigation #2

Closed
dillonredding opened this issue Jun 1, 2021 · 0 comments · Fixed by #7
Closed

Modals Don't Close After Navigation #2

dillonredding opened this issue Jun 1, 2021 · 0 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@dillonredding
Copy link
Member

dillonredding commented Jun 1, 2021 •
edited
Loading

When opening (for example) an embedded entity modal, then fetching that entity, the modal will reopen with an new embedded entity, if the fetched entity has an embedded entity with the same index as the first.
@dillonredding dillonredding added the bug Something isn't working label Jun 1, 2021
@dillonredding dillonredding changed the title Modals Don't Close After Primary Action Modals Don't Close After Navigation Jun 17, 2021
dillonredding added a commit that referenced this issue Jun 17, 2021
@dillonredding
fixing #2
a09aaab
@dillonredding dillonredding linked a pull request Jun 17, 2021 that will close this issue
v1.1.1 #7
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.1.1 siren-js/api-browser
1 participant
@dillonredding