Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix race condition for SetFormatter and SetReportCaller #1263

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix race condition for SetFormatter and SetReportCaller #1263

merged 1 commit into from
Jan 12, 2022

Conversation

rubensayshi
Copy link
Contributor

Unfortunately #1233 didn't really fix the race condition, the test just wasn't triggering the race condition to be detected...

*Entry.write just needs a lock for the whole function.

@r0mant
Copy link

r0mant commented Aug 16, 2021 •
edited
Loading

@sirupsen (or @dgsb :) ) Any chance of merging this in? Thanks!

@r0mant r0mant mentioned this pull request Aug 17, 2021
Merged
@rubensayshi
Copy link
Contributor Author

<3 thx for the bump @r0mant

ye @sirupsen or @dgsb let me know if you want to see anything changed before merging

@rubensayshi
Copy link
Contributor Author

rubensayshi commented Sep 9, 2021 •
edited
Loading

@sirupsen it's really annoying to have random pipeline failures over this every so often :/

this seems like a simply fix?

@r0mant
Copy link

r0mant commented Jan 10, 2022

@sirupsen @dgsb Bumping this again guys, any chance to get this merged in? Thanks!

@sirupsen sirupsen merged commit 85981c0 into sirupsen:master Jan 12, 2022
@sillydong sillydong mentioned this pull request Nov 30, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubensayshi @r0mant @sirupsen