Escape "query" parameter

[thinca]

"query" parameter may contains any characters such as "&".

Sorry for no tests.
I'm newbie for Go. Adding tests about them was difficult for me. 🙇

[sivchari]

Thank you for PR 😄, good catch !
Please update target branch dev-1.1 to main. I wanna apply these changes for gotwtr immediately.

[thinca]

OK. I rebased.
Note that searchAllTweets API does not not exist in main. Therefore, you need to fix it in the dev-1.1 branch.

[sivchari]

@thinca

Note that searchAllTweets API does not not exist in main. Therefore, you need to fix it in the dev-1.1 branch.

Yes, I know. I'll create PR for apply for your comment 👍

[thinca]

CI failed, but the test succeeds in my local environment.
It appears to be a cache issue in the CI environment.

[sivchari]

I used act (demonstrate github actions in local), and this CI is passed. So, I don't no idea that why is this checks is failed. You said cache issue in the CI environment, but we cached only go.sum. As these reason, the checks is failed, but I'd like to merge this PR. What do you think ?

[thinca]

Fmm... Sorry, this is not the cache problem.

https://github.com/sivchari/gotwtr/pull/121/checks#step:2:205

HEAD is now at 937d90b Merge b9c61bf into 749a04a

749a04a is a commit at dev-1.1. The CI is not updating the merge point.

I'll try update it by close/reopen this PR.

[thinca]

Oh... re-approval is needed.

[sivchari]

Hi, I comprehended, so I approve now.

[codecov]

Codecov Report

Merging #121 (b9c61bf) into main (0743c3c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files          30       30           
  Lines        1493     1493           
=======================================
  Hits          851      851           
  Misses        406      406           
  Partials      236      236           

Impacted Files	Coverage Δ
search_spaces.go	44.44% <100.00%> (-1.99%)	⬇️
search_tweet.go	46.15% <100.00%> (-1.35%)	⬇️
space_option.go	38.88% <100.00%> (+1.15%)	⬆️
tweet_counts.go	44.44% <100.00%> (-1.99%)	⬇️
tweet_option.go	41.46% <100.00%> (+0.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0743c3c...b9c61bf. Read the comment docs.