Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix trainer color bug #485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix trainer color bug #485

wants to merge 2 commits into from

Conversation

morteako
Copy link
Collaborator

@morteako morteako commented Feb 3, 2025

Fixes small bug regarding action bar color.
When disconnected, the power icon has red color, but it should have the power color, purple.

image

Also change string 'red.500' to the variable hrColor , which is theme.colors.red[500] , which should be the same

@sivertschou
Copy link
Owner

Are you sure this was a bug and not just us trying to display it as red for the error? 😅

@sivertschou
Copy link
Owner

Also, I think you have to spell use refactor: instead of refac: for the conventional commits 🤔

@morteako
Copy link
Collaborator Author

morteako commented Feb 3, 2025

Also, I think you have to spell use refactor: instead of refac: for the conventional commits 🤔

Someone should make semantic commits improved v2 version

@morteako
Copy link
Collaborator Author

morteako commented Feb 3, 2025

Are you sure this was a bug and not just us trying to display it as red for the error? 😅

Who knows. But since red is the actual color for the hr icon, it is not that obvious.
Maybe we should make them both grey instead

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants