WIP: move hasValidData to workoutState and avoid refetching datapoints #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morteako
commented
Mar 1, 2025
| @@ -117,7 +112,8 @@ export const DataContextProvider = ({ clockWorker, children }: Props) => { | |||
| }, [power, heartRate, cadence]); | |||
|
|
|||
| const start = React.useCallback(async () => { | |||
| if (trackedData.length > 0) { | |||
| if (!hasValidData) { | |||
| // was this wrong before? | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work
Haven't actually benchmarked (not sure how tbh 👀)
But my guess is that that query can be a bit intense, and seemed like it was fetched 4 times per second? (at the same time+-)
for some reason.
Here the components that need it, fetch the tracked data only when needed (upload and download, when clicked).
Will probably also reduce the amount of rerenders for these components.
BUT!
This doesnt work for the Map :S
I am not sure, but could one maybe instead change to calculate a % of the route done, and then create x-y points based on that?