-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: Make the generated README more contributor oriented #230
Conversation
That looks better, adding my notes as well as some comments on those based on your changes, from my own thinking when I was going through the older process, some of which still applies:
Maybe less the case now with these changes though maybe worth a second look all the same with that in mind and the idea later for maybe two sets of docs.
This would probably mean we'd want to move the .envrc step earlier in the doc with your change.
Just some thoughts. |
I don't understand the last part of your comment: Maybe we're on the same page and I misunderstood your last comments! 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We need a few small updates.
Co-authored-by: Roché Compaan <roche@upfrontsoftware.co.za>
dcf4dec
to
b2b067e
Compare
It would be good to merge sooner rather than later to avoid more conflicts and losing stuff. |
Merging with the idea that it's good enough to be in and might need to be improved in a later PR. |
@@ -75,7 +79,7 @@ Django Admin that will be accesible at [http://localhost:8009/admin](http://loca | |||
|
|||
To create a superuser use the following commands: | |||
|
|||
$ make shell | |||
$ make shell-backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with a newly generated project it seems like make shell-backend
no longer exists, and make shell
doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reopened a ticket about that #236
The current state of the README is quite hard to follow for people not familiar with the setup already.
One overall change was in the section titles and levels
Two very confusing sections:
To make the setup clearer for contributors I made two sections: