Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Make the generated README more contributor oriented #230

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

hillairet
Copy link
Member

The current state of the README is quite hard to follow for people not familiar with the setup already.

One overall change was in the section titles and levels

  • I used "How to ..." because it makes the purpose of the section clearer for the writer and the reader in my opinion.
  • I adjusted the section levels because it was really not consistent.

Two very confusing sections:

  1. The initialization of the github repo feels out of place because it happens once and is done by the person running scaf anyway. This should be in scaf itself, not in the generated README so I removed it
  2. The management of secrets seemed to be jumping between sealedSecrets and .envrc file so I made two clean sections instead

To make the setup clearer for contributors I made two sections:

  • one for setting up the environment, done once
  • one for spinning up the app with commands that must be run every time

@hillairet hillairet added the documentation Improvements or additions to documentation label Jun 14, 2024
@hillairet hillairet requested a review from sedatbasar June 14, 2024 15:51
@hillairet hillairet self-assigned this Jun 14, 2024
@daveoconnor
Copy link
Contributor

That looks better, adding my notes as well as some comments on those based on your changes, from my own thinking when I was going through the older process, some of which still applies:

When the developer has a new project/codebase set up the docs are orientated towards the users who will come onto the project, rather than the user who needs to set up the project.

Maybe less the case now with these changes though maybe worth a second look all the same with that in mind and the idea later for maybe two sets of docs.

E.g. The docs say the user has to install Kubectl, Kind, and Tilt, but that user already has those set up. Not bad, but still a double take moment for me. Then the user goes on reading the "Initial Project Setup" instructions, which say to run make compile which fails because of 1password secrets

This would probably mean we'd want to move the .envrc step earlier in the doc with your change.

Thoughts: This needs refinement?
At a minimum adding 1password instructions would be better before make compile, but maybe there should be two README.md, one pared back one for the initial setup which most developers will look for of habit, and a second like README_CONTRIBUTORS.md, with the first README having an instruction the follows the rest of the setup to run mv README_CONTRIBUTORS.md README.md.

Distinct instructions might make them easier to change when updating the docs too.

Alternatively, a README.mdwith two distinct sections for setup/contributors.

Just some thoughts.

@hillairet
Copy link
Member Author

I don't understand the last part of your comment:
In which situation are the steps of running scaf and setting up the generated project with make compile done by two people at two different times?
For me (and I could be totally wrong), whoever runs scaf will also setup (once!) the generated project all the way to where it can be handed off to any contributor, Sixie or not.
Therefore the project setup docs should be in the scaf root README and anything related to maintaining and developing the generated project belongs in the project's README.

Maybe we're on the same page and I misunderstood your last comments! 😅

Copy link
Contributor

@rochecompaan rochecompaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We need a few small updates.

Co-authored-by: Roché Compaan <roche@upfrontsoftware.co.za>
@hillairet
Copy link
Member Author

It would be good to merge sooner rather than later to avoid more conflicts and losing stuff.

@hillairet
Copy link
Member Author

Merging with the idea that it's good enough to be in and might need to be improved in a later PR.

@hillairet hillairet merged commit 3b3e63d into main Jul 11, 2024
4 checks passed
@hillairet hillairet deleted the hillairet/contributor-oriented-readme branch July 11, 2024 18:53
@@ -75,7 +79,7 @@ Django Admin that will be accesible at [http://localhost:8009/admin](http://loca

To create a superuser use the following commands:

$ make shell
$ make shell-backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a newly generated project it seems like make shell-backend no longer exists, and make shell doesn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reopened a ticket about that #236

rochecompaan pushed a commit that referenced this pull request Jul 23, 2024
## [1.9.0](v1.8.1...v1.9.0) (2024-07-23)

### Features

* added support for debuggers, with initial support for pycharm (close [#277](#277)) ([c2392cb](c2392cb))

### Documentation

* Make the generated README more contributor oriented ([#230](#230)) ([3b3e63d](3b3e63d))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants