Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Adds apollo graphql #275

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat: Adds apollo graphql #275

merged 4 commits into from
Jul 8, 2024

Conversation

sedatbasar
Copy link
Contributor

Overview

  • Adds apollo graphql
  • Adds auto type generation script
  • Fixes the allowed_hosts issue on local.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to .env.local since NextJS using this by default for local dev

errorInfo: ErrorInfo | null
}

class ErrorBoundary extends Component<Props, State> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this for client side errors

@@ -0,0 +1,8 @@
export default function Custom404() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is custom 404 page for nextJS

@@ -0,0 +1,3 @@
export default function Custom500() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is custom server error page for nextJS

@@ -8,7 +8,7 @@ data:
DJANGO_ADMIN_URL: "admin/"
DJANGO_SETTINGS_MODULE: "config.settings.local"
DJANGO_SECRET_KEY: "CHANGEME"
DJANGO_ALLOWED_HOSTS: "localhost,127.0.0.1,django,.{{ cookiecutter.domain_name }}"
DJANGO_ALLOWED_HOSTS: "localhost,127.0.0.1,backend,.{{ cookiecutter.domain_name }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated since we are using backend now instead of django

Copy link
Contributor

@rochecompaan rochecompaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made one comment about ALLOWED_HOST to consider.

Co-authored-by: Roché Compaan <roche@upfrontsoftware.co.za>
@sedatbasar sedatbasar merged commit c3d4f20 into main Jul 8, 2024
4 checks passed
rochecompaan pushed a commit that referenced this pull request Jul 8, 2024
## [1.8.0](v1.7.1...v1.8.0) (2024-07-08)

### Features

* Adds apollo graphql ([#275](#275)) ([c3d4f20](c3d4f20))
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants