Fix crash on multiline_function_chains rule

Fixes realm#2360
sjavora · Mar 9, 2019 · 8705610 · 8705610
1 parent 6c2e06d
commit 8705610
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,7 +27,12 @@
 
 * Fix false positive on `file_name` rule when using nested types.  
   [Marcelo Fabri](https://github.com/marcelofabri)
-  [#2325](https://github.com/realm/SwiftLint/issues/2325)  
+  [#2325](https://github.com/realm/SwiftLint/issues/2325)
+
+* Fix crash on `multiline_function_chains` rule when using some special
+  characters inside the function calls.  
+  [Marcelo Fabri](https://github.com/marcelofabri)
+  [#2360](https://github.com/realm/SwiftLint/issues/2360)
 
 ## 0.27.0: Heavy Duty
 

diff --git a/Rules.md b/Rules.md
@@ -10270,6 +10270,12 @@ let evenSquaresSum = a.b(1, 2, 3)↓.c { blah in
     .d()
 ```
 
+```swift
+a.b {
+//  ““
+}↓.e()
+```
+
 </details>
 
 

diff --git a/Source/SwiftLintFramework/Rules/Style/MultilineFunctionChainsRule.swift b/Source/SwiftLintFramework/Rules/Style/MultilineFunctionChainsRule.swift
@@ -85,6 +85,11 @@ public struct MultilineFunctionChainsRule: ASTRule, OptInRule, ConfigurationProv
                     print(blah)
                 }
                 .d()
+            """,
+            """
+            a.b {
+            //  ““
+            }↓.e()
             """
         ]
     )
@@ -197,7 +202,7 @@ public struct MultilineFunctionChainsRule: ASTRule, OptInRule, ConfigurationProv
         }
 
         let nameEndOffset = nameOffset + nameLength
-        let nameLengthDifference = parentName.bridge().length - nameLength
+        let nameLengthDifference = parentName.utf8.count - nameLength
         let offsetDifference = bodyOffset - nameEndOffset
 
         return NSRange(location: nameEndOffset + offsetDifference + bodyLength,
@@ -209,7 +214,7 @@ public struct MultilineFunctionChainsRule: ASTRule, OptInRule, ConfigurationProv
 fileprivate extension Dictionary where Key: ExpressibleByStringLiteral {
     var subcalls: [[String: SourceKitRepresentable]] {
         return substructure.compactMap { dictionary -> [String: SourceKitRepresentable]? in
-            guard case .call? = dictionary.kind.flatMap(SwiftExpressionKind.init(rawValue:)) else {
+            guard dictionary.kind.flatMap(SwiftExpressionKind.init(rawValue:)) == .call else {
                 return nil
             }
             return dictionary