Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[docs] 添加 AUTHORS 以及致谢信息 #262

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jan 8, 2018

没少谢吧

Close #238

PTAL @AlexaraWu

Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege gaocegege requested review from at15 and AlexaraWu January 8, 2018 14:49
Copy link
Collaborator

@AlexaraWu AlexaraWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors 是你手动加的么?直接链到 Contributors 页面是不是方便一点?

@gaocegege
Copy link
Member Author

代码生成大部分 + 手动维护了一丢丢: https://github.com/gaocegege/maintainer

@gaocegege
Copy link
Member Author

gaocegege commented Jan 8, 2018

是仿照 github.com/moby/moby 做的, 据说可以带给人满足感

如果觉得没必要我可以去掉..

Copy link
Member

@at15 at15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexaraWu
Copy link
Collaborator

LGTM,但是以后这个项目交给别人维护的时候这一块怎么办?

@gaocegege
Copy link
Member Author

你说的很有道理,有点增加维护负担,我改一哈

Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege
Copy link
Member Author

PTAL @AlexaraWu

Copy link
Collaborator

@AlexaraWu AlexaraWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege gaocegege merged commit a1e8e5e into sjtug:dev Jan 9, 2018
@gaocegege gaocegege deleted the ack branch January 9, 2018 02:10
gaocegege added a commit that referenced this pull request Jan 9, 2018
* README: Add ack

Signed-off-by: Ce Gao <ce.gao@outlook.com>

* README: Add development

Signed-off-by: Ce Gao <ce.gao@outlook.com>

* AUTHORS: Remove

Signed-off-by: Ce Gao <ce.gao@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants