-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[docs] 添加 AUTHORS 以及致谢信息 #262
Conversation
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authors 是你手动加的么?直接链到 Contributors 页面是不是方便一点?
代码生成大部分 + 手动维护了一丢丢: https://github.com/gaocegege/maintainer |
是仿照 github.com/moby/moby 做的, 据说可以带给人满足感 如果觉得没必要我可以去掉.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM,但是以后这个项目交给别人维护的时候这一块怎么办? |
你说的很有道理,有点增加维护负担,我改一哈 |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
PTAL @AlexaraWu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* README: Add ack Signed-off-by: Ce Gao <ce.gao@outlook.com> * README: Add development Signed-off-by: Ce Gao <ce.gao@outlook.com> * AUTHORS: Remove Signed-off-by: Ce Gao <ce.gao@outlook.com>
没少谢吧
Close #238
PTAL @AlexaraWu