Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Ruby and support Rails v8 #111

Merged

Conversation

mateuszgorniak
Copy link
Contributor

@mateuszgorniak mateuszgorniak commented Dec 3, 2024

This PR introduces several updates and improvements:

  • Ruby version upgrade

    • Updates the Ruby version used in the project to the latest release, 3.3.7.
  • Rails v8 compatibility

    • Adjusts dependency constraints to support Ruby on Rails (RoR) version 8.
    • Updates the test project and modifies the generator to use the appropriate migration version for compatibility with Rails v8.
  • Rubocop and Reek configuration update

    • Adapts config of both mentioned tools and regenerates the rubocop_todo.yml file to reflect the latest code analysis and align with updated coding standards.
  • Documentation update

    • Adds a short guide how to work with gem - Running Tests Locally section

@mateuszgorniak mateuszgorniak changed the title Update ruby and support rails v8 Update Ruby and support Rails v8 Dec 3, 2024
@mateuszgorniak mateuszgorniak marked this pull request as ready for review December 3, 2024 22:53
@mateuszgorniak
Copy link
Contributor Author

@skcc321 could you check it next days? 🙇

@skcc321
Copy link
Owner

skcc321 commented Dec 17, 2024

Great job @mateuszgorniak!
Could you please take a look at the CI results? I'll get it merged as soon as CI is green.

@mateuszgorniak mateuszgorniak force-pushed the update-ruby-and-support-rails-v8 branch from 76dda49 to 5f08fc1 Compare December 31, 2024 14:12
@mateuszgorniak mateuszgorniak force-pushed the update-ruby-and-support-rails-v8 branch from 0696ab1 to c583abb Compare December 31, 2024 15:18
@mateuszgorniak
Copy link
Contributor Author

Could we try to run workflows again @skcc321 ? :-)

@mateuszgorniak
Copy link
Contributor Author

mateuszgorniak commented Jan 7, 2025

Ok, it seems the failing checks are related to an issue caused by the latest update of the logger gem – some details here. I’ve downgraded it for the time being and added a note to ensure we remember to update it again if the issue is resolved in TruffleRuby 😄

UPDATE: Problem should be already solved and logger updated on our side 🙇

@mateuszgorniak mateuszgorniak force-pushed the update-ruby-and-support-rails-v8 branch from b6572fe to feb9170 Compare January 14, 2025 06:33
@@ -19,5 +19,9 @@ def copy_migrations
def copy_initializer
template 'deploy_pin.rb', 'config/initializers/deploy_pin.rb'
end

def migration_version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

2. **Docker**
Ensure Docker is installed and running on your machine.

#### Running the Workflow
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@skcc321 skcc321 merged commit 5e5e5cd into skcc321:master Jan 22, 2025
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants