Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Embed Font Awesome locally #1190

Closed
endigo9740 opened this issue Mar 22, 2023 · 2 comments · Fixed by #1220
Closed

Embed Font Awesome locally #1190

endigo9740 opened this issue Mar 22, 2023 · 2 comments · Fixed by #1220
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@endigo9740
Copy link
Contributor

Link to the Page

No response

Describe the Issue

For GDPR compliance we'll need to remove the remote embed of Font Awesome and instead reference this locally. This will also include performance benefits.

Are you able to create a Pull Request with the fix?

Yes

@endigo9740 endigo9740 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 22, 2023
@endigo9740 endigo9740 self-assigned this Mar 22, 2023
@endigo9740 endigo9740 pinned this issue Mar 22, 2023
@Sarenor
Copy link
Contributor

Sarenor commented Mar 25, 2023

Using web fonts apparently needs npm integration via env variable during the build as demonstrated here:
https://fontawesome.com/docs/web/setup/packages

Might be a problem during local development and definitely needs to be set up during build time, which only people with Vercel access can do.

@endigo9740
Copy link
Contributor Author

endigo9740 commented Mar 28, 2023

@Sarenor if you were referring to setting up the font awesome token, that's only for pro plans. We stick to free icons, which means we can skip that step!

Screenshot 2023-03-28 at 12 57 22 PM

I'll follow through the rest of the instructions and see if I can get this going now.

edit

I see...

Or if you're using environment variables, you can do this instead:

But again I think we can skip this as it does seem optional. The free set should suffice for us.

@endigo9740 endigo9740 linked a pull request Mar 28, 2023 that will close this issue
@endigo9740 endigo9740 unpinned this issue Mar 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants