Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Font Awesome local install #1220

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Font Awesome local install #1220

merged 2 commits into from
Mar 29, 2023

Conversation

endigo9740
Copy link
Contributor

Fixes #1190

@endigo9740 endigo9740 linked an issue Mar 28, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:41PM (UTC)

@endigo9740
Copy link
Contributor Author

@Sarenor So I tried using the NPM package, but was running into deployment issue with it trying to authenticate and failing. Very odd stuff, never see anything like that. So I said screw it and switched to the self hosted solution here:

https://fontawesome.com/docs/web/setup/host-yourself/webfonts

It's nearly the same process as our recent font update, with the static files stored in the /static directory. This appears to work, at least as a stop gap solution. A couple notable issues though - I can't seem to import the files via the root layout, which means they may or may not be included as part of Vite's bundling process.

Additionally, this is a bit old school, meaning if things update we'll have to update the local assets manually. Thankfully we don't do this very often. But to keep things simple I've installed ONLY what we're using:

  1. fontawesome.min.css - the core stylesheet which is required
  2. brands.min.css - various brand icons, such as the social link icons in the page footer
  3. solid.min.css - the default solid version of icons

All three are using the minified files which should provide a minor improvement. But for now I think this is the best we can get.

Feel free to poke holes in this, otherwise we'll move forward and merge this soon.

@Sarenor
Copy link
Contributor

Sarenor commented Mar 28, 2023

At least as far as GDPR is concerned that seems fine.
Otherwise I'll need to poke holes in this tomorrow, finally got time for games today :D

@Sarenor
Copy link
Contributor

Sarenor commented Mar 29, 2023

Haven't checked every page on the site, but homepage and a couple of components I've scrolled over look good 👍

@endigo9740 endigo9740 merged commit bd36a42 into dev Mar 29, 2023
@endigo9740 endigo9740 deleted the chore/font-awesome-local branch March 29, 2023 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Font Awesome locally
2 participants