Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add "Copy to Clipboard" feature to Code Blocks #204

Closed
endigo9740 opened this issue Sep 7, 2022 · 4 comments · Fixed by #210 or #244
Closed

Add "Copy to Clipboard" feature to Code Blocks #204

endigo9740 opened this issue Sep 7, 2022 · 4 comments · Fixed by #210 or #244
Assignees
Labels
enhancement New feature or request ready to test Ready to be tested for quality assurance.

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 7, 2022

Reference:
https://mantine.dev/core/code/

This seems like an obvious use case for the newly requested action. Though the action will need to exist before this is possible.

This is a blocking prerequisite:
#199

@endigo9740 endigo9740 added the enhancement New feature or request label Sep 7, 2022
@niktek
Copy link
Contributor

niktek commented Sep 7, 2022

I'll take this one!

@endigo9740
Copy link
Contributor Author

endigo9740 commented Sep 8, 2022

FYI @niktek, you are more than welcome to use a standard <button> element for the Code Block copy button. That would allow you to retain full control over the styling, no need to fight with the Button component styles. This would mean the Svelte action could be applied in the standard manner.

Also, if you need a "copy" icon Font Awesome has a good one. Just add it to the SVGIcon set:
https://fontawesome.com/icons/copy?s=solid&f=classic

This was linked to pull requests Sep 20, 2022
@endigo9740
Copy link
Contributor Author

Re-opening and marking "ready for QA"

@endigo9740 endigo9740 reopened this Sep 20, 2022
@endigo9740 endigo9740 added the ready to test Ready to be tested for quality assurance. label Sep 20, 2022
@endigo9740
Copy link
Contributor Author

Released!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request ready to test Ready to be tested for quality assurance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants