-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve Component Consistency #194
Comments
The list above shows general changes, while the list below shows specific changes per item. ComponentsApp Shell
App Bar
Accordion
Alerts
Avatars
Badges
Breadcrumbs
Buttons
Cards
Data TablesDividers
Default Gradient Heading
Lists
Svelte Component:
Tailwind Element: Used for UL, OL, DL, and NAV lists Logo Cloud
MenusPaginators
Progress Bars
Progress Radials
Radio Groups
Range Sliders
Slide Toggles
Steppers
Tabs
TooltipsUtilitiesCode BlockDrawers
DialogsToastsLight Switch
ActionsCopy to ClipboardFilters
|
This is ready to test! Everyone is welcome to pull down the PR and test locally. Please submit your feedback here. Thanks! |
Note I've completed a round of updates. The first was just general QA and cleanup fixes. The second added more "selector classes", the id-like classes we use to describe each element within the component templates. |
Merged this into dev, but reopening this ticket so QA can continue forward over the next week. |
@endigo9740 you can start with these ones for now before I am done with the rest |
@salisshuaibu11 The button component wasn't touched in this update. It's been pulled to it's own dedicated ticket. But I noted your posted on there already. We're adding interactive examples over time as I'm still settled on the best way to handle a few things. We'll have them for most components eventually. Though some like Cards work a bit better as is. Let's chat about the Breacrumb a bit more tomorrow. I'd like to hear your thoughts. Thanks though, this is a great start! |
Safari (of course) doesn't show the initials on components/avatars even though the rendered HTML has it and it shows fine in other browsers like Chrome. |
Safari..... http://localhost:5173/components/range-sliders Accent doesn't work. Works fine in other browsers. |
Per Avatars - I'm using the same technique as the progress radio for SVG text - which scale responsively. So I'll check both! Per Radio Sliders - yeah, I'm aware. Hopefully they resolve that soon! |
@salisshuaibu11 @niktek The items you mentioned above have been fixed and changes push to @salisshuaibu11 I didn't include the Avatar |
Is okay, is clear now. |
I've created a new ticket to track the progress on items not completed in this upcoming release: |
Part 1 is released. Part 2 coming up soon! |
We've created and implemented a lot of new design patterns and paradigms over the last few months. I think it would be useful to go through and ensure all components are in sync with the latest standards.
NOTE: THIS UPDATE WILL INTRODUCE BREAKING CHANGES
Code Consistency
borderSize
changed toborderWidth
to match Tailwind/CSSringSize
changed toringWidth
to match Tailwindvariants
, we should favor Tailwind class props$$props.class
has a fallback of''
to removeundefined
appearing in DOMComponent Docs
$$restProps
have this documented clearlyDesign Consistency
Introduce Tailwind Elements
We've opted to deprecate several components in favor of static Tailwind CSS styled elements.
The text was updated successfully, but these errors were encountered: