Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add new "region" props for supplying arbitrary styles #223

Closed
endigo9740 opened this issue Sep 13, 2022 · 3 comments
Closed

Add new "region" props for supplying arbitrary styles #223

endigo9740 opened this issue Sep 13, 2022 · 3 comments
Labels
feature request Request a feature or introduce and update to the project. help wanted Extra attention is needed

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 13, 2022 •
edited
Loading

This is an extension of the consistent updates:

This process has been started for several components, but needs to be extended to all. To see an example refer to the updates to the AppBar on the feat/consistency branch, or review dev once that's merged.

My recommendation is we note these new classes on the Slots table per each component doc. Just add a column called Style Prop and including the class name, such as slotDefault for the default slot.
@endigo9740 endigo9740 added documentation Improvements or additions to documentation enhancement New feature or request feature request Request a feature or introduce and update to the project. labels Sep 13, 2022
@endigo9740 endigo9740 self-assigned this Sep 13, 2022
@endigo9740 endigo9740 mentioned this issue Sep 13, 2022
Closed
14 tasks
@endigo9740
Copy link
Contributor Author

Alternative idea: don't focus purely on slots, but rather "regions". This is more general purpose!

@endigo9740 endigo9740 changed the title Add wrapping slot props for passing arbitrary styles Add new "region" props for supplying arbitrary props Sep 21, 2022
@endigo9740 endigo9740 changed the title Add new "region" props for supplying arbitrary props Add new "region" props for supplying arbitrary styles Sep 21, 2022
@endigo9740 endigo9740 added help wanted Extra attention is needed and removed documentation Improvements or additions to documentation enhancement New feature or request labels Oct 3, 2022
@endigo9740
Copy link
Contributor Author

See me on this, I can explain. It won't be difficult to add, just need to find the time!

@endigo9740 endigo9740 removed their assignment Oct 3, 2022
@endigo9740 endigo9740 mentioned this issue Oct 7, 2022
Closed
@endigo9740
Copy link
Contributor Author

I'm going to table this for now. It may return in the future though as a more standardized feature.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature request Request a feature or introduce and update to the project. help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@endigo9740