Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NEXT Svelte Popover snippet has inaccurate description #3044

Closed
endigo9740 opened this issue Dec 11, 2024 · 3 comments
Closed

NEXT Svelte Popover snippet has inaccurate description #3044

endigo9740 opened this issue Dec 11, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 11, 2024

Reported here: #2919 (comment)

I've found documentation inconsistency, doc states that the Popover, Modal and Tooltip components could have custom trigger element such as button

image

But actually there's already hard-coded button provided with no way to override it:

{#if trigger}
<button {...api.getTriggerProps()} class="{triggerBase} {triggerBackground} {triggerClasses}">
{@render trigger()}
</button>

<!-- Snippet: Trigger -->
<button {...api.getTriggerProps()} class="{triggerBase} {triggerBackground} {triggerClasses}">
{@render trigger?.()}
</button>

<!-- Snippet: Trigger -->
<button {...api.getTriggerProps()} class="{triggerBase} {triggerBackground} {triggerClasses}">
{@render trigger?.()}
</button>

Originally posted by @codercms in #2919 (comment)

@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Dec 11, 2024
@endigo9740 endigo9740 added the documentation Improvements or additions to documentation label Dec 11, 2024
@phamduylong
Copy link
Contributor

I'll throw a docs update, changing the description to something like: Provide the template contents of the trigger button.

@endigo9740
Copy link
Contributor Author

That would be great @phamduylong

Just FYI I'm working through this backlog of smaller issues this week, starting with bugfixes. So you'll likely notice those thinning out. If you could please keep calling out the issues you want so we don't double up.

@phamduylong
Copy link
Contributor

Thanks for the notice Chris. I'll try to update along the way. And don't hesitate to ping me if the issues were to pile up and you need help 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants