Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat/popup tooltip #1332

Closed
wants to merge 2 commits into from
Closed

Feat/popup tooltip #1332

wants to merge 2 commits into from

Conversation

saturnonearth
Copy link
Contributor

@saturnonearth saturnonearth commented Apr 14, 2023

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

Adds basic tooltip functionality so someone can easily add inline tooltips to elements without having to create separate popup elements on the page.

This is still a work in progress. I still need to:

  • Create element dynamically instead of always existing on page
  • Destroy dynamically created element when tooltip is hidden
  • Make sure all types are correct

If anyone can help with destroying/creating the element on the fly, that would be great.

Docs

  • Provide more examples
  • Make sure description is correct
  • Make sure params, etc all work
  • References to Popup where appropriate

Additional features

I would love to have some sort of top level wrapper that allows any elements with a "title" attribute to display a tooltip on hover. This seems sort of like a separate PR though.

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 8:06pm

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 21, 2023

@saturnonearth I see the benefit of this change, however I still believe this is something that can be worked into the current popup iteration. Give this, I'm going to close out this PR. However, I have noted it as a potential update for the upcoming popup refactor detailed here:

@endigo9740 endigo9740 closed this Apr 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants