Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature | Added LineNumbers Property to Code Block #1437

Merged

Conversation

LukeHagar
Copy link
Contributor

@LukeHagar LukeHagar commented May 5, 2023

Closes #1241

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 5:53pm

@endigo9740
Copy link
Contributor

endigo9740 commented May 5, 2023

@LukeHagar I made a number of changes:

  1. Moved the CSS to Element styles, to match conventions with the rest of the library
  2. Improved the line number spans to have a fixed width. Otherwise each digit would shift things to the right by that amount. (ex: 10, 100, 1000 would be uneven)
  3. Adjusted the demo text just slightly and implemented the opt-in typography
  4. Dropped a const no longer used in the codeblock logic

Per the opt-in typography, this is a new addition this release. Be sure you're doing your PRs against the latest dev updates, it seemed you were a bit behind so the title and code tag showed like this:

Screenshot 2023-05-05 at 12 38 10 PM

@endigo9740 endigo9740 merged commit 24f338a into skeletonlabs:dev May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CodeBlock prop: lineNumber
2 participants