Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix: Properly display all component classes for our TW plugin's intellisense #1664

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

AdrianGonz97
Copy link
Member

Linked Issue

Closes #1650

Description

This PR aims to patch this bug for users of Skeleton v1.

This has already been fixed for our upcoming plugin overhaul #1660.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: e747506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jun 14, 2023 1:18pm

@endigo9740
Copy link
Contributor

@AdrianGonz97 I likely won't have time to review this this week so I've added @niktek in case he can beat me to this. But if you feel confident on the changes I trust you on this one. You can merge when ready.

@endigo9740
Copy link
Contributor

@AdrianGonz97 I went ahead and squeezed some time in to review this. All looks well so I'm merging now.

@endigo9740 endigo9740 merged commit b93a512 into skeletonlabs:dev Jun 14, 2023
@AdrianGonz97 AdrianGonz97 deleted the fix/missing-intellisense branch June 21, 2023 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

variant-ringed-primary not working in intellisense
2 participants