stopping ios change text after reset #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghe
reviewed
Mar 2, 2018
| @@ -206,7 +211,7 @@ export default class MentionsTextInput extends Component { | |||
| } | |||
|
|
|||
| isSelectionReplaced() { | |||
| return this.triggerMatrix | |||
There was a problem hiding this comment.
good catch, I never would have seen that extra space
greghe
reviewed
Mar 2, 2018
| @@ -76,11 +76,16 @@ export default class MentionsTextInput extends Component { | |||
| } | |||
|
|
|||
| resetTextbox() { | |||
| this.isResetting = true; | |||
There was a problem hiding this comment.
When adding new member variables, it's a good practice to declare them above the constructor:
isResetting: boolean;
It's also a good practice to add declarations for existing members, time permitting.
|
Please add |
greghe
reviewed
Mar 2, 2018
| triggerMatrix: Array<Object>; | ||
| isResetting: boolean; | ||
| isTrackingStarted: boolean; | ||
| isSelectionChangeHandled: boolean; |
There was a problem hiding this comment.
You win today's "go the extra mile award"
|
👍 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.