Skip to content

[PS-6258] Removing react-native Dependency #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

[PS-6258] Removing react-native Dependency #4

merged 1 commit into from
Jul 16, 2019

Conversation

MLawlz
Copy link

@MLawlz MLawlz commented Jul 16, 2019

  • Removing react-native as a dependency since hasteImpl crashes yarn thinking that there's a duplicate module name from this.
  • Confirmed that Trophies V2 still works with this change by pointing our sdk-ota package.json to this branch and building/running again.

sree98
sree98 approved these changes Jul 16, 2019
View reviewed changes
Copy link

@sree98 sree98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

TGier
TGier approved these changes Jul 16, 2019
View reviewed changes
Copy link

@TGier TGier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MLawlz MLawlz merged commit d1b258c into master Jul 16, 2019
@MLawlz MLawlz deleted the Removing-React-Native-Dependency branch July 16, 2019 18:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sree98 sree98 sree98 approved these changes

@TGier TGier TGier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MLawlz @sree98 @TGier