Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[vue] Change path to match default inertia.js path #4

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

noxasch
Copy link
Contributor

@noxasch noxasch commented Jul 21, 2024

In the docs it seems assume createInertiaApp is located in a file in the same level as pages folder. But in actual, we have to go up one directory to access pages, hence if we copy and paste the default layout from the documentation, the page will failed.

p/s: Not sure about other framework setup. Also thanks for the updated rails inertia documentation !

Ensure proper path for vue page components
Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for inertia-rails ready!

Name Link
🔨 Latest commit 8e60880
🔍 Latest deploy log https://app.netlify.com/sites/inertia-rails/deploys/66a11a61beeee90008c63aca
😎 Deploy Preview https://deploy-preview-4--inertia-rails.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@noxasch noxasch changed the title Change vue path to match default inertia.js path [vue] Change path to match default inertia.js path Jul 21, 2024
@PedroAugustoRamalhoDuarte
Copy link
Contributor

@noxasch thanks for this change, very important for new users from Inertia Rails. For other frameworks is the same thing, we need to change to ../pages

Copy link
Contributor

@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noxasch

@skryukov skryukov merged commit 849b4df into skryukov:main Jul 24, 2024
5 checks passed
@skryukov skryukov mentioned this pull request Jul 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants