Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mesh-of-edges feature #711

Merged
merged 22 commits into from
Dec 12, 2022
Merged

Conversation

ted-ross
Copy link
Member

@ted-ross ted-ross commented Sep 7, 2022

This feature creates a new connection role called inter-edge. This can be used to create full-meshes of edge routers that may be connected to an interior network of routers. The main benefit is that edge sites in a network can be scaled up to include multiple routers without a) requiring inter-edge traffic to flow via the interior or b) eating into the budget of interior routers (128 max) because you had to use interior routers at the edge.

In an edge-mesh, all local traffic flows between the edge routers directly (one hop maximum).

Mesh of Edges Notes.pdf

@ted-ross ted-ross self-assigned this Sep 7, 2022
@ted-ross ted-ross force-pushed the tross-edge-mesh branch 5 times, most recently from 82877d7 to 2f8c678 Compare September 22, 2022 19:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 27.94% // Head: 27.63% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (d9c2327) compared to base (52fddf5).
Patch coverage: 9.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   27.94%   27.63%   -0.31%     
==========================================
  Files         134      136       +2     
  Lines       31852    32393     +541     
  Branches     5091     5200     +109     
==========================================
+ Hits         8901     8953      +52     
- Misses      21814    22291     +477     
- Partials     1137     1149      +12     
Flag Coverage Δ
unittests 27.63% <9.60%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/qpid/dispatch/parse.h 100.00% <ø> (ø)
src/amqp.c 88.23% <ø> (ø)
src/router_core/agent_connection.c 0.00% <0.00%> (ø)
src/router_core/agent_link.c 0.00% <0.00%> (ø)
src/router_core/connections.c 2.60% <0.00%> (-0.05%) ⬇️
src/router_core/forwarder.c 2.54% <0.00%> (-0.08%) ⬇️
...ules/address_lookup_client/address_lookup_client.c 12.28% <0.00%> (-0.22%) ⬇️
...re/modules/edge_addr_tracking/edge_addr_tracking.c 1.75% <0.00%> (-0.21%) ⬇️
src/router_core/modules/edge_router/addr_proxy.c 0.00% <0.00%> (ø)
...uter_core/modules/edge_router/connection_manager.c 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ted-ross ted-ross force-pushed the tross-edge-mesh branch 5 times, most recently from 084d1e4 to ec40698 Compare September 26, 2022 13:51
@ted-ross ted-ross force-pushed the tross-edge-mesh branch 4 times, most recently from 5c4328a to cce992f Compare November 2, 2022 18:29
@ted-ross ted-ross force-pushed the tross-edge-mesh branch 2 times, most recently from 72504a5 to 147f52d Compare November 7, 2022 21:38
@ted-ross ted-ross marked this pull request as ready for review November 8, 2022 21:01
@ted-ross ted-ross changed the title Working PR for mesh-of-edges feature Mesh-of-edges feature Nov 8, 2022
@ted-ross ted-ross requested a review from kgiusti November 10, 2022 17:00
Copy link
Contributor

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Some in-line nits and comment requests for your consideration but nothing to hold up landing this. Nice work!

@ted-ross ted-ross merged commit 185aafa into skupperproject:main Dec 12, 2022
@ted-ross ted-ross deleted the tross-edge-mesh branch December 12, 2022 18:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants