Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement type-safe accessors for the project implementations in Gradle files #80

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

piloudu
Copy link
Contributor

@piloudu piloudu commented Apr 4, 2023

Guidelines

Implement type-safe references to the projects in the Gradle file. This is achieved by enabling the enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") configuration in the settings.gradle.kts file.

Types of changes

Here I introduce a technical improvement, that shouldn't impact the functionality in any means.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Technical improvement.

Preparing a pull request for review

Ensure your change is properly formatted --> ✅

Please correct any failures before requesting a review.

@piloudu piloudu requested a review from skydoves as a code owner April 4, 2023 06:20
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@skydoves skydoves merged commit 8ac703d into skydoves:main Apr 4, 2023
@piloudu
Copy link
Contributor Author

piloudu commented Apr 4, 2023

Thanks man! And the project looks great to me @skydoves !

I've just learned by surfing through the code that it's possible to use the versions catalog in the Gradle Project::plugins block by using libs*.get().pluginId. Great one!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants