fix(deobf): resolve NPE when package is empty (if rename is disabled)

skylot · Apr 26, 2020 · e3f388a · e3f388a
1 parent 8319662
commit e3f388a
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/jadx-core/src/main/java/jadx/core/deobf/PackageNode.java b/jadx-core/src/main/java/jadx/core/deobf/PackageNode.java
@@ -31,14 +31,17 @@ public String getName() {
 	public String getFullName() {
 		if (cachedPackageFullName == null) {
 			Deque<PackageNode> pp = getParentPackages();
-
-			StringBuilder result = new StringBuilder();
-			result.append(pp.pop().getName());
-			while (!pp.isEmpty()) {
-				result.append(SEPARATOR_CHAR);
+			if (pp.isEmpty()) {
+				cachedPackageFullName = "";
+			} else {
+				StringBuilder result = new StringBuilder();
 				result.append(pp.pop().getName());
+				while (!pp.isEmpty()) {
+					result.append(SEPARATOR_CHAR);
+					result.append(pp.pop().getName());
+				}
+				cachedPackageFullName = result.toString();
 			}
-			cachedPackageFullName = result.toString();
 		}
 		return cachedPackageFullName;
 	}