Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[feature] Add Logcat output into debugger #1411

Closed
jmlitfi opened this issue Mar 18, 2022 · 2 comments
Closed

[feature] Add Logcat output into debugger #1411

jmlitfi opened this issue Mar 18, 2022 · 2 comments
Labels
debugger new feature

Comments

@jmlitfi
Copy link
Contributor

jmlitfi commented Mar 18, 2022

I would like the Jadx debugger to include the logcat output within the Jadx GUI. Ive been building the feature and have it working for my purposes but not quite ready to include into production. Creating this issue to get others opinion.

Currently can be found at https://github.com/green9317/jadx/tree/logcatAddition

jadx_logcat_example

Before I submit I still want to add

  1. ability to filter to debugged process
  2. automatically update process list
  3. button to clear logcat
  4. button to pause logcat (for performance sensitive users)
  5. Change how logcat output is displayed to make it easier to read
  6. clean code
@skylot
Copy link
Owner

skylot commented Mar 18, 2022

@green9317 looks nice! Great work!
One small request: please rebase your branch on latest master branch, your base commit (a62de83) feels outdated 🙂

@jmlitfi
Copy link
Contributor Author

jmlitfi commented Mar 19, 2022

Ill do that. I wasn't sure if not having the latest commit would cause an issue when I do a pull request.

@jmlitfi jmlitfi mentioned this issue Sep 8, 2022
Merged
skylot added a commit that referenced this issue Sep 8, 2022
@jmlitfi @skylot
feat(debugger): add logcat output (#1411)(PR #1666)
9114821 
* Adding logcatController class and writing adb / debugger panel information to the controller.

* Finished parsing logcat binary output and writing an arraylist containing all events.

* added highlighting of logcat output based on type.  Added timestamp parsing.

* Updated code to only get new log messages.

* Added additional code for select all

* Completed Check and uncheckall options.

* Changed log highlighting to log color.  Changed from JTextArea to JTextPane. Logcat pane will now autoscroll only if it is already scrolled to the bottom.  Debugger exit will now stop logcat as well.

* Moved labels into NLS rather than using hardcoded strings.

* Implemented the ability to autoselect attached process.  Changed the formatting of logcat messages.

* Moved labels into NLS rather than using hardcoded strings.

* updating to use info getter methods rather than directly accessing variable

* Added Logcat Pause Button

* Added Clear button

* Updated clear icon

* Cleaning warnings

* cleaning

* Changed behavior to only show logcat for debugged process to start with.

* cleaning

* cleaning

* cleaning

* applying spotless

* Fixing bug with switch

* fixed formatting issue

* add missing localization strings

Co-authored-by: green9317 <38409554+green9317@users.noreply.github.com>
Co-authored-by: TheCobraChicken <jeffmlitfi@gmail.com>
Co-authored-by: Skylot <skylot@gmail.com>
@skylot skylot closed this as completed Sep 8, 2022
@anantshri anantshri mentioned this issue Oct 20, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
debugger new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skylot @jpstotz @jmlitfi