[gui] Opening apk with added blank space to its filename lead to crash

[de-served]

Issue details

1. Copy filepath & filename with ... terminal? file manager? grab more than needed - with additional space after "filename.apk" so buffer will contain "Drive:\Path\filename.apk "
2. Start jadx-...exe
3. Insert filename from buffer to open file dialog
4. Try to execute "open"

java.nio.file.InvalidPathException: Trailing char < > at index 80: D:\Projects\Android\e9ac2df792ef.apk
at java.base/sun.nio.fs.WindowsPathParser.normalize(Unknown Source)
at java.base/sun.nio.fs.WindowsPathParser.parse(Unknown Source)
at java.base/sun.nio.fs.WindowsPathParser.parse(Unknown Source)
at java.base/sun.nio.fs.WindowsPath.parse(Unknown Source)
at java.base/sun.nio.fs.WindowsFileSystem.getPath(Unknown Source)

Jadx version

1.5.0

Java version

22.0.1, 21.x etc

OS

• Windows
• Linux
• macOS

[skylot]

This is not a crash, just provide a correct file path.

[de-served]

Maybe just add a trim?
I use Far manager 20+ years
If everyone using it insert filename to commandline with Ctrl-Enter it will add a space at the end awaiting to add any options to commandline.
jadx is the first app for... IDK... 5 years maybe... maybe more... that will react to path with spaces after/before (not inside, of course) as it acts.

[skylot]

Maybe just add a trim?

Done.
@de-served please check latest unstable build.
In fix, trailing spaces removed only for files opened with file dialog.
This issue is only appearing in Windows. Linux implementation of File.toPath() do not check for trailing spaces.
Although, all systems allow having files with trailing spaces.
So jadx now made changes to input paths that can be considered an issue like this 🤣

[de-served]

So jadx now made changes to input paths that can be considered an issue like this

Yep... This is crazy enough (when files/dirs have trailing spaces that is hard to observe if it is at the end)