Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(gui): Smali code folding #2233

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

Mino260806
Copy link
Contributor

Adds code folding for

  • .class
  • .method

image

@Mino260806
Copy link
Contributor Author

Mino260806 commented Aug 1, 2024

Screenshot_2024-08-01-18-46-35-414_com.github.android.jpg

I think this needs another method visitPatternStartOffsets() (uses matcher.start() not matcher.end())

Sorry for bad formatting I'm on phone

Edit: same for getStartMethodStartOffsets, it's my fault

@skylot
Copy link
Owner

skylot commented Aug 1, 2024

@Mino260806 sorry, I undo method extract, because these methods are all different now 🙂

Edit:
Also, it is funny that it is still working well with any start/end offset 🤣

@skylot skylot merged commit 1669200 into skylot:master Aug 1, 2024
5 checks passed
@Mino260806 Mino260806 deleted the code_folding_smali branch August 1, 2024 22:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants