feat(gui): Quick Tabs Overhaul

[Mino260806]

• (internal) Decentralize Tabs Controlling code to a seperate TabsController class. (*1)
• Add Open Tabs parent node in Quick Tabs that allows users to view tabs that are open
• Add Bookmarked Tabs parent node in Quick Tabs that allows users to bookmark tabs and keep a reference even when the tab is closed

Unchecked tasks are WIP

---

(*1) This change is a must. Previously, TabbedPane was the only class interacting with tabs. So it was fine that all the code that controls tabs was found there. However now, that we are adding QuickTabsTree, (and why not other components), it no longer makes sense that QuickTabsTree needs to communicate with TabbedPane in order to manage the tabs. Counter example ? There may be tabs which are not open in TabbedPane but are present in QuickTabsTree, like bookmarked tabs. So if we would keep using old code, we'd have to store in TabbedPane a seperate reference to tabs that are present but not open, which would transform the code into a mess. I hope you understood the point.

Now TabsController hold a "generic reference" to each tab, and TabbedPane holds a "component reference".

Before

Now

---

Affected issues

• closes [feature] Bookmarks and search history #1448
• closes [feature] Add the ability to bookmark a node for later reference #1078

Icons from https://intellij-icons.jetbrains.design

[skylot]

Looks good, but I found some issues and request small improvements 🙂

[skylot]

One more thing.
I notice that on reload (or close jadx-gui and open project again) tabs order changes.
To reproduce, move any tab to other position and press reload action (from toolbar or F5) and tabs will reorder.
Not sure, maybe that was broken before this commit, but as soon as we change saving code here it is better to use actual tabs order on project save.

[Mino260806]

@skylot all ready

[skylot]

Hm, not sure why we need to save index to restore order, is just saving/reading tabs list in correct order not working?

[Mino260806]

Hm, not sure why we need to save index to restore order, is just saving/reading tabs list in correct order not working?

TabsController now holds the generic reference to each TabBlueprint through a Map<JNode, TabBlueprint>, I avoided saving the tabs in the TabbedPane order because

• it would require a callback to TabbedPane before saving tabs that reorders TabBlueprint and saves them back, and we would need filtering for tabs that are hidden
• we would anyway use the same procedure (store index) if we wanted to also preserve order for QuickTabs and allow reordering later on

But maybe we can just consider the order of TabbedPane to be the "default" order, ok I'll implement it by saving/reading tabs list in correct order

[Mino260806]

@skylot please see commit 6ca79d4. I implemented saving/reading tabs list in correct order

[skylot]

OK, I think we can merge it now.
Although, here is a small list of thing for future improvements:

• There are still a lot of calls using TabbedPane instead TabsController. Like in MainWindow we call method in TabbedPane next it calls TabsController, and it calls TabbedPane again 🤣. This is confusing and not follow architecture you draw 😭
• It feels like onTabsReorder method implementation has very high complexity (like 2*n^2) and can take a lot of time for lots of tabs and bookmarks, so it is better to optimize it. And in general feels like that we are very often iterating over lists in search of one element, maybe some additional map will help.
• Please do not use ArrayList as a variable type, it is considered a bad practice in Java. I think checkstyle has rule for that (this), I will enable it and fix all such places.

[Mino260806]

Although, here is a small list of thing for future improvements

All noted. I'll open a new PR in the near future